Page 3 of 3 FirstFirst 123
Results 21 to 28 of 28

Thread: amrecover with S3 tape stops after 2 blocks

  1. #21
    Join Date
    Nov 2005
    Location
    Canada
    Posts
    1,045

    Default

    I think you find the problem.

    Can you do another test to be sure?
    In recover-src/extract_list.c,change the line 2015 form
    Code:
    g_ptr_array_add(argv_ptr, g_strdup("-xpGvf"));
    to
    Code:
    g_ptr_array_add(argv_ptr, g_strdup("-xpGf"));
    (remove the 'v' flag)

    tar will write nothing, so it should not hang, amrecover will not show the list of files, but the extraction should succeed

  2. #22
    Join Date
    Mar 2017
    Posts
    14

    Default

    Thanks for this - that seems to work around the issue. I assume that's not the proper fix(!)?

    Also - whilst I was building today , I had to add a section to packaging/rpm/amanda.spec.src to get it to build on Centos 6:

    Code:
        %if %(awk '$1 == "CentOS" && $3 ~ /6.*/ { exit 1; }' /etc/redhat-release; echo $?)
            %define dist redhat
            %define disttag rhel
            %define distver 6
            %define curl curl
        %endif
    Could this be included?

    Let me know if you come up with a full patch for this - I'd be happy to test it for you.

    Dave

  3. #23
    Join Date
    Nov 2005
    Location
    Canada
    Posts
    1,045

    Default

    Try the attached patch!

    Don't forget to re-add the 'v' falg in the tar command
    Code:
    g_ptr_array_add(argv_ptr, g_strdup("-xpGvf"));
    Attached Files Attached Files

  4. #24
    Join Date
    Nov 2005
    Location
    Canada
    Posts
    1,045

    Default

    I committed the fix to packaging/rpm/amanda.spec.src

  5. #25
    Join Date
    Mar 2017
    Posts
    14

    Default

    Thanks for that. I tried the patch and that seems to fully resolve the issue. Many thanks for turning this round so quickly.

    One other thing - I noticed that the rpm uninstall script was broken - there is a fix for it here:

    https://github.com/driseley/amanda/commit/92a54bac8800b297aa30b220ae7bad8aaa39bf95

    Would this fix for amrecover be included in your next release?

    Kind Regards
    Dave

  6. #26
    Join Date
    Nov 2005
    Location
    Canada
    Posts
    1,045

    Default

    All fixes are committed and will be in 3.4.4.

    Thanks for your help, you did a great job to identify the bug.

  7. #27
    Join Date
    Mar 2017
    Posts
    14

    Default

    No problems - thanks for fixing it!

    Kind Regards
    Dave

  8. #28

    Default

    i'll try to figure out this problem

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •