amrecover with S3 tape stops after 2 blocks

[martineau]

I think you find the problem.

Can you do another test to be sure?
In recover-src/extract_list.c,change the line 2015 form

g_ptr_array_add(argv_ptr, g_strdup("-xpGvf"));

to

g_ptr_array_add(argv_ptr, g_strdup("-xpGf"));

(remove the 'v' flag)

tar will write nothing, so it should not hang, amrecover will not show the list of files, but the extraction should succeed

[droa]

Thanks for this - that seems to work around the issue. I assume that's not the proper fix(!)?

Also - whilst I was building today , I had to add a section to packaging/rpm/amanda.spec.src to get it to build on Centos 6:

    %if %(awk '$1 == "CentOS" && $3 ~ /6.*/ { exit 1; }' /etc/redhat-release; echo $?)
        %define dist redhat
        %define disttag rhel
        %define distver 6
        %define curl curl
    %endif

Could this be included?

Let me know if you come up with a full patch for this - I'd be happy to test it for you.

Dave

[martineau]

Try the attached patch!

Don't forget to re-add the 'v' falg in the tar command

g_ptr_array_add(argv_ptr, g_strdup("-xpGvf"));

[martineau]

I committed the fix to packaging/rpm/amanda.spec.src

[droa]

Thanks for that. I tried the patch and that seems to fully resolve the issue. Many thanks for turning this round so quickly.

One other thing - I noticed that the rpm uninstall script was broken - there is a fix for it here:

https://github.com/driseley/amanda/commit/92a54bac8800b297aa30b220ae7bad8aaa39bf95

Would this fix for amrecover be included in your next release?

Kind Regards
Dave

[martineau]

All fixes are committed and will be in 3.4.4.

Thanks for your help, you did a great job to identify the bug.

[droa]

No problems - thanks for fixing it!

Kind Regards
Dave

[abanghasan]

i'll try to figure out this problem