Results 1 to 4 of 4

Thread: problem with chg-disk and slot numbers greater 9

  1. #1

    Default problem with chg-disk and slot numbers greater 9

    Hi,

    i hope i'm in the correct place her for this, i couldn't find any other place to send a patch ...

    we have an problem with chg-disk and slot numbers greater 9
    if we have 10 or more slots as virtual tapes, in our case 18, slot1 wouldn't be loaded.

    The problem seems in the Amanda::Changer::disk.pm, in the _get_next function in the line:
    # Otherwise, search through all slots
    my @all_slots = $self->_all_slots();
    my $prev = $all_slots[-1];
    for $next_slot (@all_slots) {
    return $next_slot if ($prev == $slot);
    $prev = $next_slot;
    }

    after the function _all_slots deliveres an lexical sorted list of list, not numerical, the the number 18 would be before 2 and not 1

    to fix this short we had patched the function _all_slots to give back an numerical sorted list, so the behavior would be right.

    i add an patch against the 3.1.2 source code
    Attached Files Attached Files

  2. #2
    Join Date
    Mar 2007
    Location
    Chicago, IL
    Posts
    688

    Default

    Thanks! I've committed the patch in r3419.

    Generally the best place for patches is on the amanda-users or amanda-hackers mailing lists - [url]http://amanda.org/support/mailinglists.php[/url].

    Please let us know of any other fixes or improvements you might have!
    Storage Software Engineer
    Zmanda, Inc.

  3. #3

    Default

    thx for the commit and the information, i will keep the mailing lists in mind

    this was the only fix we needed by now

  4. #4
    Join Date
    Aug 2008
    Posts
    184

    Thumbs up

    Great. Please do post details about your configuration, storage device(s) used, observed performance etc. These details are very useful for other Amanda users.

    Thanks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •